[Mesa-dev] [PATCH] clover: Require libelf

[Tom Stellard]

On Mon, Oct 20, 2014 at 05:44:53PM -0400, Jan Vesely wrote:
> From: Jan Vesely <jan.vesely at rutgers.edu>
> 
> CC: Tom Stellard <tom at stellard.net>
> CC: Emil Velikov <emil.l.velikov at gmail.com>
> CC: Francisco Jerez <currojerez at riseup.net>
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
> 
> This fixes clover build failures when building without radeon
> 
>  configure.ac | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 0ed9325..c3c42af 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1495,6 +1495,8 @@ if test "x$enable_opencl" = xyes; then
>      else
>          OPENCL_LIBNAME="OpenCL"
>      fi
> +    AC_CHECK_LIB([elf], [elf_memory], [ELF_LIB=-lelf],
> +                                 [AC_MSG_ERROR([$1 requires libelf when using LLVM])])

I think it would be better to do the libelf checks once like:

AC_CHECK_LIB([elf], [elf_memory], [have_libelf=yes; ELF_LIB=-lelf])

And then do:

if test "x$have_libelf" != xyes; then
   AC_MSG_ERROR([Clover required libelf])
fi

For both clover and radeon.

-Tom

>  fi
>  AM_CONDITIONAL(HAVE_CLOVER, test "x$enable_opencl" = xyes)
>  AM_CONDITIONAL(HAVE_CLOVER_ICD, test "x$enable_opencl_icd" = xyes)
> -- 
> 2.0.4
>