[Mesa-dev] [PATCH 14/15] i965: Silence unused parameter warnings in brwIsProgramNative

Kenneth Graunke kenneth at whitecape.org
Thu Oct 23 11:12:33 PDT 2014


On Thursday, October 23, 2014 09:35:29 AM Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> brw_program.c: In function 'brwIsProgramNative':
> brw_program.c:123:39: warning: unused parameter 'ctx' [-Wunused-
parameter]
> brw_program.c:124:13: warning: unused parameter 'target'
> [-Wunused-parameter] brw_program.c:125:25: warning: unused 
parameter 'prog'
> [-Wunused-parameter]
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_program.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_program.c
> b/src/mesa/drivers/dri/i965/brw_program.c index 3de96ae..ab1b741 
100644
> --- a/src/mesa/drivers/dri/i965/brw_program.c
> +++ b/src/mesa/drivers/dri/i965/brw_program.c
> @@ -124,6 +124,10 @@ brwIsProgramNative(struct gl_context *ctx,
>  		   GLenum target,
>  		   struct gl_program *prog)
>  {
> +   (void) ctx;
> +   (void) target;
> +   (void) prog;
> +
>     return true;
>  }

You could instead remove this driver hook.  If the dd pointer is NULL, 
arbprogram.c will return true.  I think I'd prefer that.

Series is also:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141023/23b3ea1a/attachment.sig>


More information about the mesa-dev mailing list