[Mesa-dev] [PATCH 02/10] i965: Disassemble vector float immediates properly.

[Francisco Jerez]

Francisco Jerez <currojerez at riseup.net> writes:

> Matt Turner <mattst88 at gmail.com> writes:
>
>> ---
>>  src/mesa/drivers/dri/i965/brw_disasm.c | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c
>> index 53ec767..6f5290e 100644
>> --- a/src/mesa/drivers/dri/i965/brw_disasm.c
>> +++ b/src/mesa/drivers/dri/i965/brw_disasm.c
>> @@ -31,6 +31,7 @@
>>  #include "brw_defines.h"
>>  #include "brw_reg.h"
>>  #include "brw_inst.h"
>> +#include "brw_packed_float.h"
>>  
>>  const struct opcode_desc opcode_descs[128] = {
>>     [BRW_OPCODE_MOV]      = { .name = "mov",     .nsrc = 1, .ndst = 1 },
>> @@ -1009,7 +1010,11 @@ imm(FILE *file, struct brw_context *brw, unsigned type, brw_inst *inst)
>>        format(file, "0x%08xUV", brw_inst_imm_ud(brw, inst));
>>        break;
>>     case BRW_HW_REG_IMM_TYPE_VF:
>> -      format(file, "Vector Float");
>> +      format (file, "[%.7f, %.7f, %.7f, %.7f]VF",
>
Oh, and wouldn't it make sense to use the same specifier we use for
float arguments "%-gF" so we get a consistent formatting in the
disassembly?

> Unnecessary space between the function name and parenthesis.  With that
> fixed:
> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
>
>> +              brw_vf_to_float(brw_inst_imm_ud(brw, inst)),
>> +              brw_vf_to_float(brw_inst_imm_ud(brw, inst) >> 8),
>> +              brw_vf_to_float(brw_inst_imm_ud(brw, inst) >> 16),
>> +              brw_vf_to_float(brw_inst_imm_ud(brw, inst) >> 24));
>>        break;
>>     case BRW_HW_REG_IMM_TYPE_V:
>>        format(file, "0x%08xV", brw_inst_imm_ud(brw, inst));
>> -- 
>> 2.0.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141024/2915e881/attachment.sig>