[Mesa-dev] [PATCH 2/5] mesa: Implement ARB_clip_control.

Matt Turner mattst88 at gmail.com
Fri Oct 24 14:34:57 PDT 2014


On Wed, Oct 22, 2014 at 10:22 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
>> index da35684..ed1f390 100644
>> --- a/src/mesa/main/get_hash_params.py
>> +++ b/src/mesa/main/get_hash_params.py
>> @@ -414,6 +414,8 @@ descriptor=[
>>    [ "AUX_BUFFERS", "BUFFER_INT(Visual.numAuxBuffers), NO_EXTRA" ],
>>    [ "BLUE_BIAS", "CONTEXT_FLOAT(Pixel.BlueBias), NO_EXTRA" ],
>>    [ "BLUE_SCALE", "CONTEXT_FLOAT(Pixel.BlueScale), NO_EXTRA" ],
>> +  [ "CLIP_DEPTH_MODE", "CONTEXT_ENUM(ClipControl.Depth), NO_EXTRA" ],
>> +  [ "CLIP_ORIGIN", "CONTEXT_ENUM(ClipControl.Origin), NO_EXTRA" ],
>
> Don't you need to check for ARB_clip_control being enabled? So like an
> EXTRA_clip_control + relevant define or whatever (don't remember
> exactly how that stuff works).

Yes, this hunk is wrong.


More information about the mesa-dev mailing list