[Mesa-dev] [PATCH] i965/fs: Change the type of booleans to UD and emit correct immediates

Matt Turner mattst88 at gmail.com
Tue Oct 28 11:56:46 PDT 2014


On Thu, Oct 16, 2014 at 3:40 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> Before, we used the a signed d-word for booleans and the immedates we
> emitted varried between signed and unsigned.  This commit changes the type
> to unsigned (I think that makes more sense) and makes immediates more
> consistent.  This allows copy propagation to work better cleans up some
> instructions.
>
> total instructions in shared programs: 5473519 -> 5465864 (-0.14%)
> instructions in affected programs:     432849 -> 425194 (-1.77%)
> GAINED:                                27
> LOST:                                  0

I assumed at first that this was on Haswell, but it couldn't be
because Haswell doesn't use 0/1 for boolean. What platform was this?

I checked shader-db on Haswell, and the result were less impressive (4
programs affected):

total instructions in shared programs: 5510067 -> 5510063 (-0.00%)
instructions in affected programs:     168 -> 164 (-2.38%)
GAINED:                                0
LOST:                                  0


More information about the mesa-dev mailing list