[Mesa-dev] [PATCH] i965/fs: Change the type of booleans to UD and emit correct immediates

[Kenneth Graunke]

On Tuesday, October 28, 2014 12:10:11 PM Jason Ekstrand wrote:
> On Oct 28, 2014 11:57 AM, "Matt Turner" <mattst88 at gmail.com> wrote:
> >
> > On Thu, Oct 16, 2014 at 3:40 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > > Before, we used the a signed d-word for booleans and the immedates we
> > > emitted varried between signed and unsigned.  This commit changes the
> type
> > > to unsigned (I think that makes more sense) and makes immediates more
> > > consistent.  This allows copy propagation to work better cleans up some
> > > instructions.
> > >
> > > total instructions in shared programs: 5473519 -> 5465864 (-0.14%)
> > > instructions in affected programs:     432849 -> 425194 (-1.77%)
> > > GAINED:                                27
> > > LOST:                                  0
> >
> > I assumed at first that this was on Haswell, but it couldn't be
> > because Haswell doesn't use 0/1 for boolean. What platform was this?
> 
> It doesn't matter what form of booleans the arch uses.  I believe it was on
> HSW.  However, as I have mentioned in private, I've had trouble running
> shaderdb and believing the results.  They could be bogus but I don't think
> so.

I've never had a single problem with it - the results always appeared 
accurate.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141028/d6ac44e8/attachment.sig>