[Mesa-dev] [PATCH 02/14] i965: Generalize fs_generator further

Matt Turner mattst88 at gmail.com
Tue Oct 28 17:30:45 PDT 2014

On Tue, Oct 28, 2014 at 3:59 PM, Matt Turner <mattst88 at gmail.com> wrote:
>>> -   assert(stage == MESA_SHADER_FRAGMENT);
>> I like removing these asserts from the function bodies, but I'm
>> confused why you're doing it. The VS isn't going to call
>> fire_fb_write, or emit a derivative instruction.
> Oh, you're actually removing the stage member entirely. Isn't that
> useful to have?
> Maybe I need to keep reading the series..

Okay, still don't understand. It seems like your objective in patch 3
is to be able to print things other than "fragment" under various
INTEL_DEBUG=... settings. Wouldn't it be simpler to contain that logic
in the generator using the stage member -- which would be nice to have
for assertions anyway?

More information about the mesa-dev mailing list