[Mesa-dev] [PATCH] i965: add missing parens in vec4 visitor

[Chris Forbes]

Oops.

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

On Tue, Sep 2, 2014 at 12:14 PM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> coverity reported this, Matt said it look like missing parens,
> not bad identing, so lets try that.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index ce94db8..fbf3d01 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -2579,7 +2579,7 @@ vec4_visitor::visit(ir_texture *ir)
>        } else if (ir->op == ir_txf_ms) {
>           emit(MOV(dst_reg(MRF, param_base + 1, sample_index_type, WRITEMASK_X),
>                    sample_index));
> -         if (brw->gen >= 7)
> +         if (brw->gen >= 7) {
>              /* MCS data is in the first channel of `mcs`, but we need to get it into
>               * the .y channel of the second vec4 of params, so replicate .x across
>               * the whole vec4 and then mask off everything except .y
> @@ -2587,6 +2587,7 @@ vec4_visitor::visit(ir_texture *ir)
>              mcs.swizzle = BRW_SWIZZLE_XXXX;
>              emit(MOV(dst_reg(MRF, param_base + 1, glsl_type::uint_type, WRITEMASK_Y),
>                       mcs));
> +         }
>           inst->mlen++;
>        } else if (ir->op == ir_txd) {
>          const glsl_type *type = lod_type;
> --
> 1.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev