[Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

[Tapani Pälli]

Yep, it should be allocating just the pointers.

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 09/02/2014 02:22 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Coverity reported this, and I think this is the right solution,
> since cache->items is struct cache_item ** not struct cache_item *,
> we also realloc it using struct cache_item * at some point.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/mesa/program/prog_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/program/prog_cache.c b/src/mesa/program/prog_cache.c
> index 07192a9..34609f0 100644
> --- a/src/mesa/program/prog_cache.c
> +++ b/src/mesa/program/prog_cache.c
> @@ -143,7 +143,7 @@ _mesa_new_program_cache(void)
>     if (cache) {
>        cache->size = 17;
>        cache->items =
> -         calloc(1, cache->size * sizeof(struct cache_item));
> +         calloc(cache->size, sizeof(struct cache_item *));
>        if (!cache->items) {
>           free(cache);
>           return NULL;