[Mesa-dev] [PATCH 2/2] radeonsi: Compile dummy pixel shader on demand

[Michel Dänzer]

On 01.09.2014 19:08, Marek Olšák wrote:
> On Wed, Aug 27, 2014 at 10:57 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> It's never used under normal circumstances.
>>
>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>> ---
>>   src/gallium/drivers/radeonsi/si_pipe.c  |  7 -------
>>   src/gallium/drivers/radeonsi/si_state.c | 11 ++++++++++-
>>   2 files changed, 10 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
>> index ae1d043..f39529a 100644
>> --- a/src/gallium/drivers/radeonsi/si_pipe.c
>> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
>> @@ -27,7 +27,6 @@
>>
>>   #include "radeon/radeon_uvd.h"
>>   #include "util/u_memory.h"
>> -#include "util/u_simple_shaders.h"
>>   #include "vl/vl_decoder.h"
>>
>>   /*
>> @@ -129,12 +128,6 @@ static struct pipe_context *si_create_context(struct pipe_screen *screen, void *
>>                  goto fail;
>>          sctx->blitter->draw_rectangle = r600_draw_rectangle;
>>
>> -       sctx->dummy_pixel_shader =
>> -               util_make_fragment_cloneinput_shader(&sctx->b.b, 0,
>> -                                                    TGSI_SEMANTIC_GENERIC,
>> -                                                    TGSI_INTERPOLATE_CONSTANT);
>> -       sctx->b.b.bind_fs_state(&sctx->b.b, sctx->dummy_pixel_shader);
>
> This removes binding the dummy shader at context creation, but I don't
> remember if it is still needed. Hopefully not.

AFAICT it isn't, certainly not for piglit.


> For the series:
>
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Thanks, pushed.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer