[Mesa-dev] [PATCH 02/14] i965: Rename fs_generator to scalar_generator

Kenneth Graunke kenneth at whitecape.org
Tue Sep 2 12:10:54 PDT 2014


On Monday, September 01, 2014 09:44:26 AM Jordan Justen wrote:
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/Makefile.sources         |    2 +-
>  src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h      |    2 +-
>  src/mesa/drivers/dri/i965/brw_fs.cpp               |    4 +-
>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp     | 2009 -------------------
>  src/mesa/drivers/dri/i965/brw_scalar.h             |   20 +-
>  src/mesa/drivers/dri/i965/brw_scalar_generator.cpp | 2011 ++++++++++++++++++++
>  6 files changed, 2025 insertions(+), 2023 deletions(-)
>  delete mode 100644 src/mesa/drivers/dri/i965/brw_fs_generator.cpp
>  create mode 100644 src/mesa/drivers/dri/i965/brw_scalar_generator.cpp

I think this patch makes a lot of sense.  The generator is going to be used for FS, VS, HS, DS, and compute programs, and having all of that in a single class is not a crazy plan - it's pretty much dumb/straightforward code generation without a lot of specific stage knowledge.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140902/9d461238/attachment.sig>


More information about the mesa-dev mailing list