[Mesa-dev] [PATCH] i965: Mark cfg dumping functions const.

Kenneth Graunke kenneth at whitecape.org
Thu Sep 4 00:41:03 PDT 2014


The dump() methods don't alter the CFG or basic blocks, so we should
mark them as const.  This lets you call them even if you have a const
cfg_t - which is the case in certain portions of the code (such as live
interval handling).

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_cfg.cpp | 4 ++--
 src/mesa/drivers/dri/i965/brw_cfg.h   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp b/src/mesa/drivers/dri/i965/brw_cfg.cpp
index 8714b68..e67b13a 100644
--- a/src/mesa/drivers/dri/i965/brw_cfg.cpp
+++ b/src/mesa/drivers/dri/i965/brw_cfg.cpp
@@ -145,7 +145,7 @@ bblock_t::combine_with(bblock_t *that)
 }
 
 void
-bblock_t::dump(backend_visitor *v)
+bblock_t::dump(backend_visitor *v) const
 {
    int ip = this->start_ip;
    for (backend_instruction *inst = (backend_instruction *)this->start;
@@ -420,7 +420,7 @@ cfg_t::make_block_array()
 }
 
 void
-cfg_t::dump(backend_visitor *v)
+cfg_t::dump(backend_visitor *v) const
 {
    foreach_block (block, this) {
       fprintf(stderr, "START B%d", block->num);
diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h
index ca6a2ac..7985a97 100644
--- a/src/mesa/drivers/dri/i965/brw_cfg.h
+++ b/src/mesa/drivers/dri/i965/brw_cfg.h
@@ -62,7 +62,7 @@ struct bblock_t {
    bool is_successor_of(const bblock_t *block) const;
    bool can_combine_with(const bblock_t *that) const;
    void combine_with(bblock_t *that);
-   void dump(backend_visitor *v);
+   void dump(backend_visitor *v) const;
 #endif
 
    struct exec_node link;
@@ -100,7 +100,7 @@ struct cfg_t {
    void set_next_block(bblock_t **cur, bblock_t *block, int ip);
    void make_block_array();
 
-   void dump(backend_visitor *v);
+   void dump(backend_visitor *v) const;
 #endif
    void *mem_ctx;
 
-- 
2.0.0



More information about the mesa-dev mailing list