[Mesa-dev] [PATCH 01/20] glapi: add ARB_gpu_shader_fp64 (v2)

[Kai Wasserbäch]

Hi Dave,
just a small comment, since I'm not really the right person to review this patch:

Dave Airlie schrieb am 04.09.2014 06:15:
> [...]
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 04fa86b..00f9b19 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -669,24 +669,24 @@ const struct function gl_core_functions_possible[] = {
>     { "glVertexAttribP4uiv", 43, -1 },
>     { "glDrawArraysIndirect", 43, -1 },
>     { "glDrawElementsIndirect", 43, -1 },
> -// { "glUniform1d", 43, -1 },                           // XXX: Add to xml
> -// { "glUniform2d", 43, -1 },                           // XXX: Add to xml
> -// { "glUniform3d", 43, -1 },                           // XXX: Add to xml
> -// { "glUniform4d", 43, -1 },                           // XXX: Add to xml
> -// { "glUniform1dv", 43, -1 },                          // XXX: Add to xml
> -// { "glUniform2dv", 43, -1 },                          // XXX: Add to xml
> -// { "glUniform3dv", 43, -1 },                          // XXX: Add to xml
> -// { "glUniform4dv", 43, -1 },                          // XXX: Add to xml
> -// { "glUniformMatrix2dv", 43, -1 },                    // XXX: Add to xml
> -// { "glUniformMatrix3dv", 43, -1 },                    // XXX: Add to xml
> -// { "glUniformMatrix4dv", 43, -1 },                    // XXX: Add to xml
> -// { "glUniformMatrix2x3dv", 43, -1 },                  // XXX: Add to xml
> -// { "glUniformMatrix2x4dv", 43, -1 },                  // XXX: Add to xml
> -// { "glUniformMatrix3x2dv", 43, -1 },                  // XXX: Add to xml
> -// { "glUniformMatrix3x4dv", 43, -1 },                  // XXX: Add to xml
> -// { "glUniformMatrix4x2dv", 43, -1 },                  // XXX: Add to xml
> -// { "glUniformMatrix4x3dv", 43, -1 },                  // XXX: Add to xml
> -// { "glGetUniformdv", 43, -1 },                        // XXX: Add to xml
> +   { "glUniform1d", 40, -1 },
> +   { "glUniform2d", 40, -1 },
> +   { "glUniform3d", 40, -1 },
> +   { "glUniform4d", 40, -1 },
> +   { "glUniform1dv", 40, -1 },
> +   { "glUniform2dv", 40, -1 },
> +   { "glUniform3dv", 40, -1 },
> +   { "glUniform4dv", 40, -1 },
> +   { "glUniformMatrix2dv", 40, -1 },
> +   { "glUniformMatrix3dv", 40, -1 },
> +   { "glUniformMatrix4dv", 40, -1 },
> +   { "glUniformMatrix2x3dv", 40, -1 },
> +   { "glUniformMatrix2x4dv", 40, -1 },
> +   { "glUniformMatrix3x2dv", 40, -1 },
> +   { "glUniformMatrix3x4dv", 40, -1 },
> +   { "glUniformMatrix4x2dv", 40, -1 },
> +   { "glUniformMatrix4x3dv", 40, -1 },
> +   { "glGetUniformdv", 43, -1 },
                          ^^
Shouldn't this be a 40 as well?

Cheers,
Kai



-- 

Kai Wasserbäch (Kai Wasserbaech)

E-Mail: kai at dev.carbon-project.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 648 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140904/8d2ead63/attachment.sig>