[Mesa-dev] [Mesa-stable] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

[Emil Velikov]

On 04/09/14 02:50, Carl Worth wrote:
> Carl Worth <cworth at cworth.org> writes:
>> Emil Velikov <emil.l.velikov at gmail.com> writes:
>>>
>>> I will not have the chance to run piglit on a i965 system until next
>>> week so I would love if someone can take a look at this.
>>
>> I should be able to take a look at this today or tomorrow.
> 
> I didn't see any failures on i965. Oddly, piglit doesn't seem to be
> running this test for me, (maybe I'm missing all glean testing from
> piglit?!---I'll debug that later.). For now, I'm running this test
> manually with:
> 
> 	./bin/glean -o -v -v -v -t +fragProg1
> 
There is a recent bug in piglit (+ it's fix [1]) that causes the env vars used
not to be printed in the HTML test summary.

Additionally the command alone does not run the tests in question :'(

Give the patches a try and/or manually set the env vars similar to the ones
I've used [2].

>>> As a former stable-release manager would you have any suggestions -
>>> should I pull it out from the upcoming 10.2.7 ? I would not be too
>>> fussed it only swrast regresses, yet I'm suspecting that other classic
>>> drivers could be affected.
>>
>> Right. If piglit shows a regression, (on anything), I would recommend
>> not including the patch.
> 
> I still stand by that policy.
> 
> But, while I did find a failure of this test on swrast, I wasn't able to
> identify this patch as a regression. I see this same testing failing
> similarly on both mesa-10.2.6 and 10.2-branchpoint.
> 
I am a bit more lenient on the classic swrast, considering the fact that the
gallium one is used most of the time. I'm starting to lean towards your
suggestion though. If there is another driver affected - the patch will be
flying out :)

Thanks
Emil

[1] Two bugs actually - lack of env var + missing # in the escape chars,
causing an invalid link in the HTML summary :)

http://lists.freedesktop.org/archives/piglit/2014-September/012435.html
http://lists.freedesktop.org/archives/piglit/2014-September/012429.html


[2]
[glean/fragProg1-CMP]

PIGLIT_SOURCE_DIR="/home/emil/development/piglit/install-3457f015314/usr/local/lib/piglit"
MESA_DEBUG="silent" PIGLIT_PLATFORM="mixed_glx_egl" PIGLIT_TEST="CMP test"


[glean/glsl1-Preprocessor test 11 (#elif)]

PIGLIT_SOURCE_DIR="/home/emil/development/piglit/install-3457f015314/usr/local/lib/piglit"
MESA_DEBUG="silent" PIGLIT_PLATFORM="mixed_glx_egl" PIGLIT_TEST="Preprocessor
test 11 (#elif)"


> Let me know if I can be of any further assistance.
> 
> -Carl
> 
> 
> 
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
>