[Mesa-dev] [PATCH 3/3] gallivm: (trivial) don't try to use rcp when the division 1/x is integer

[Brian Paul]

On 09/08/2014 05:56 AM, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
>
> This would just crash. Noticed by accident while checking int divisions by zero
> with a quickly hacked piglit test.
> ---
>   src/gallium/auxiliary/gallivm/lp_bld_arit.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c
> index 8f3b568..f9c0799 100644
> --- a/src/gallium/auxiliary/gallivm/lp_bld_arit.c
> +++ b/src/gallium/auxiliary/gallivm/lp_bld_arit.c
> @@ -1073,7 +1073,7 @@ lp_build_div(struct lp_build_context *bld,
>
>      if(a == bld->zero)
>         return bld->zero;
> -   if(a == bld->one)
> +   if(a == bld->one && type.floating)
>         return lp_build_rcp(bld, b);
>      if(b == bld->zero)
>         return bld->undef;
>

For all 3, Reviewed-by: Brian Paul <brianp at vmware.com>