[Mesa-dev] [Mesa-stable] [PATCH] Suppress any "libGL:..." warnings when LIBGL_DEBUG == "quiet"

[Stefan Dirsch]

On Mon, Sep 08, 2014 at 04:51:37PM +0100, Emil Velikov wrote:
> Gents,
> 
> Can anyone review this trivial patch ?
> 
> Stefan, Johannes
> Why do I need to register in order to view the bugreport ? Afaict it is not a
> security issue, so I believe the bug should be publicly accessible.

Sorry, the bug has been reported against our sle12 business product (closed
beta program). I'm wondering that you could access it at all. I've meanwhile
cloned the bug to the openSUSE bug area, which should be accessible by
everybody - after registering to Novell's bugzilla. :-( Sorry for that
inconvenience.

  https://bugzilla.novell.com/show_bug.cgi?id=895730

I didn't try to upstream this yet, since I wasn't convinced about the full
correctness of the patch. It doesn't make use of a threshold and a verbose
level which is done in src/glx/dri_common.c:dri_message(). Looking at
__driUtilMessage() more closely a verbose level isn't given anyway. So
probably the patch isn't that bad.

If you believe the patch is ok, please feel free to push it. You do have my
"Signed-off-by: Stefan Dirsch <sndirsch at suse.de>".

Hope this helps.

Thanks,
Stefan

> On 26/08/14 21:47, Johannes Obermayr wrote:
> > From: Stefan Dirsch <sndirsch at suse.de>
> > 
> > Let's handle LIBGL_DEBUG env. variable in Mesa in a consistent way.
> > 
> > Fixes: https://bugzilla.novell.com/show_bug.cgi?id=892896
> > ---
> > To: mesa-dev at lists.freedesktop.org
> > Cc: "10.3" <mesa-stable at lists.freedesktop.org>
> > openSUSE maintainers: Why can't you forward your applied u_* patches to upstream
> >                       to get them included in final/next release?
> > ---
> >  src/mesa/drivers/dri/common/xmlconfig.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/mesa/drivers/dri/common/xmlconfig.c b/src/mesa/drivers/dri/common/xmlconfig.c
> > index ce37647..8e48522 100644
> > --- a/src/mesa/drivers/dri/common/xmlconfig.c
> > +++ b/src/mesa/drivers/dri/common/xmlconfig.c
> > @@ -429,8 +429,10 @@ static void
> >  __driUtilMessage(const char *f, ...)
> >  {
> >      va_list args;
> > +    const char *libgl_debug;
> >  
> > -    if (getenv("LIBGL_DEBUG")) {
> > +    libgl_debug=getenv("LIBGL_DEBUG");
> > +    if (libgl_debug && !strstr(libgl_debug, "quiet")) {
> >          fprintf(stderr, "libGL: ");
> >          va_start(args, f);
> >          vfprintf(stderr, f, args);

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
--------------------------------------------------------------
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix
Imendörffer, HRB 16746 (AG Nürnberg)
--------------------------------------------------------------