[Mesa-dev] [PATCH] radeonsi: Simplify si_dma_copy_tile function

[Michel Dänzer]

On 11.09.2014 00:28, Grigori Goronzy wrote:
> On 10.09.2014 10:54, Michel Dänzer wrote:
>> From: Michel Dänzer <michel.daenzer at amd.com>
>>
>> +	array_mode = si_array_mode(rtiled->surface.level[tiled_lvl].mode);
>
> Wouldn't it be more consistent to pull the array_mode from the tile mode
> array like other parameters?

I don't have a strong opinion on that either way, but it doesn't make a 
difference unless there's a bug elsewhere.


> That will break old kernels, but I think it should be okay by now. We
> could maybe disable tiled DMA copies completely on those.

Patches welcome. :) The purpose of this patch was only to simplify the 
function without any functional change.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer