[Mesa-dev] [PATCH] radeonsi: Fix si_dma_copy(_tile) for compressed formats

Michel Dänzer michel at daenzer.net
Thu Sep 11 02:06:34 PDT 2014


On 11.09.2014 07:05, Marek Olšák wrote:
> Sorry, the function is too confusing for me to understand it, but it
> looks good.

Thanks, but unfortunately, it breaks the fbo-generatemipmap-formats test 
with compressed formats for some reason. Investigating that now.


> I think it would be cleaner to convert all parameters of the
> compressed texture copy into a non-compressed texture copy at the
> beginning of si_dma_copy, with the box being (x/4, y/4, w/4, h/4),
> i.e. blitting whole blocks instead of pixels. Then, all the other
> DMA functions don't have to worry about compressed textures in
> theory.

Thanks for the suggestion, I'll keep that in mind.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer


More information about the mesa-dev mailing list