[Mesa-dev] [PATCH 2/2] i965: Separate gl_InstanceID and gl_VertexID uploading.

[Kenneth Graunke]

On Friday, September 12, 2014 08:37:11 AM Ian Romanick wrote:
> On 09/10/2014 03:41 PM, Kenneth Graunke wrote:
> > We always uploaded them together, mostly out of laziness - both required
> > an additional vertex element.  However, gl_VertexID now also requires an
> > additional vertex buffer for storing gl_BaseVertex; for non-indirect
> > draws this also means uploading (a small amount of) data.  This is extra
> > overhead we don't need if the shader only uses gl_InstanceID.
> > 
> > In particular, our clear shaders currently use gl_InstanceID for doing
> > layered clears, but don't need gl_VertexID.
> > 
> > XXX: Needs testing on Broadwell before pushing.
> 
> Has this happened yet?

Yes, it seems fine.  "arb_transform_feedback2-draw-auto -auto instanced" appeared to fail originally, which was creepy, but subsequent runs show it passing, so I guess it must have been a fluke.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140912/77be788a/attachment.sig>