[Mesa-dev] [PATCH 5/5] gallivm: attach DataLayout to module too, not just pass manager.

sroland at vmware.com sroland at vmware.com
Mon Sep 15 11:51:22 PDT 2014


From: Rafael Ávila de Espíndola <rafael.espindola at gmail.com>

It looks like it was possible to attach it to both for a long time, however
since llvm r217548 attaching it to just the pass manager is no longer
sufficient and causes bugs (see http://llvm.org/bugs/show_bug.cgi?id=20903).

Tested-by: Vinson Lee <vlee at freedesktop.org>
---
 src/gallium/auxiliary/gallivm/lp_bld_init.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_init.c b/src/gallium/auxiliary/gallivm/lp_bld_init.c
index ce87b8c..243d248 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_init.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_init.c
@@ -139,6 +139,7 @@ enum LLVM_CodeGenOpt_Level {
 static boolean
 create_pass_manager(struct gallivm_state *gallivm)
 {
+   char *td_str;
    assert(!gallivm->passmgr);
    assert(gallivm->target);
 
@@ -146,8 +147,14 @@ create_pass_manager(struct gallivm_state *gallivm)
    if (!gallivm->passmgr)
       return FALSE;
 
+   // Old versions of LLVM get the DataLayout from the pass manager.
    LLVMAddTargetData(gallivm->target, gallivm->passmgr);
 
+   // New ones from the Module.
+   td_str = LLVMCopyStringRepOfTargetData(gallivm->target);
+   LLVMSetDataLayout(gallivm->module, td_str);
+   free(td_str);
+
    if ((gallivm_debug & GALLIVM_DEBUG_NO_OPT) == 0) {
       /* These are the passes currently listed in llvm-c/Transforms/Scalar.h,
        * but there are more on SVN.
-- 
1.9.1



More information about the mesa-dev mailing list