[Mesa-dev] [PATCH] llvmpipe: fix PIPE_FORMAT_Z24_UNORM_S8_UINT depth on big endian

Alex Deucher alexdeucher at gmail.com
Mon Sep 15 13:57:11 PDT 2014


On Mon, Sep 15, 2014 at 4:48 PM, Dave Airlie <airlied at gmail.com> wrote:
>>
>> I never really looked at the big endian stuff so I have no idea if this
>> is right. I thought though the channel shift thing now should work
>> without endianness awareness if you fetch one 32bit number and then
>> break it up into parts with shifts due to the channel information being
>> adjusted for big/little endian. I could be wrong though, but if it
>> doesn't work that means there's probably some more mixup elsewhere (util
>> or llvmpipe code for clearing has its own conversion, and obviously the
>> format fetch used for depth texturing needs to match too).
>>
>
> Well I was mainly look at the code in u_format_zs.c that has big
> endian handlers, and since this code directly loads from memory I
> assumed it would need the same treatment,
>
> however it seems a bit more subtle since we regress a few tests, but
> pass a couple of hundred more, so I'll see if I can figure out what
> else is missing.

Maybe some of Richard Sandiford's patches from June will shed some light?
http://lists.freedesktop.org/archives/mesa-dev/2014-July/063723.html
http://lists.freedesktop.org/archives/mesa-dev/2014-July/063751.html

Alex


>
> Dave.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list