[Mesa-dev] [PATCH 1/2] i965/vec4: slightly improve insn dumping with no srcs

[Kenneth Graunke]

On Tuesday, September 09, 2014 07:55:28 PM Chris Forbes wrote:
> Previously, we would get a trailing ', ' which looked strange.
> 
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> ---
>  src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> index cda097f..1d1e29d 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> @@ -1337,7 +1337,10 @@ vec4_visitor::dump_instruction(backend_instruction *be_inst, FILE *file)
>        if (inst->dst.writemask & 8)
>           fprintf(file, "w");
>     }
> -   fprintf(file, ":%s, ", brw_reg_type_letters(inst->dst.type));
> +   fprintf(file, ":%s", brw_reg_type_letters(inst->dst.type));
> +
> +   if (inst->src[0].file != BAD_FILE)
> +      fprintf(file, ", ");
>  
>     for (int i = 0; i < 3 && inst->src[i].file != BAD_FILE; i++) {
>        if (inst->src[i].negate)
> 

Both are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140916/70b1b3fb/attachment.sig>