[Mesa-dev] [PATCH 1/5] mesa: Remove some dead helper functions.

Brian Paul brianp at vmware.com
Fri Sep 19 06:40:19 PDT 2014


The series looks good to me.  Nice catches.
Reviewed-by: Brian Paul <brianp at vmware.com>

-Brian


On 09/18/2014 05:32 PM, Kenneth Graunke wrote:
> Dead since the _MaxElement removal, but these functions seemed generally
> applicable, so I decided to remove them in a separate patch.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>   src/mesa/main/arrayobj.h | 26 --------------------------
>   1 file changed, 26 deletions(-)
>
> diff --git a/src/mesa/main/arrayobj.h b/src/mesa/main/arrayobj.h
> index 1819cd1..3c1f918 100644
> --- a/src/mesa/main/arrayobj.h
> +++ b/src/mesa/main/arrayobj.h
> @@ -78,32 +78,6 @@ extern void
>   _mesa_update_vao_client_arrays(struct gl_context *ctx,
>                                  struct gl_vertex_array_object *vao);
>
> -
> -/** Returns the bitmask of all enabled arrays in fixed function mode.
> - *
> - *  In fixed function mode only the traditional fixed function arrays
> - *  are available.
> - */
> -static inline GLbitfield64
> -_mesa_array_object_get_enabled_ff(const struct gl_vertex_array_object *vao)
> -{
> -   return vao->_Enabled & VERT_BIT_FF_ALL;
> -}
> -
> -/** Returns the bitmask of all enabled arrays in arb/glsl shader mode.
> - *
> - *  In arb/glsl shader mode all the fixed function and the arb/glsl generic
> - *  arrays are available. Only the first generic array takes
> - *  precedence over the legacy position array.
> - */
> -static inline GLbitfield64
> -_mesa_array_object_get_enabled_arb(const struct gl_vertex_array_object *vao)
> -{
> -   GLbitfield64 enabled = vao->_Enabled;
> -   return enabled & ~(VERT_BIT_POS & (enabled >> VERT_ATTRIB_GENERIC0));
> -}
> -
> -
>   /*
>    * API functions
>    */
>



More information about the mesa-dev mailing list