[Mesa-dev] [PATCH 08/12] i965/fs: Make null_reg_* const members of fs_visitor instead of globals

Matt Turner mattst88 at gmail.com
Mon Sep 22 10:51:14 PDT 2014


On Fri, Sep 19, 2014 at 8:16 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
>
> On Fri, Sep 19, 2014 at 5:37 PM, Matt Turner <mattst88 at gmail.com> wrote:
>>
>> On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand <jason at jlekstrand.net>
>> wrote:
>> > We also set the register width equal to the dispatch width.  Right now,
>> > this is effectively a no-op since we don't do anything with it.
>> > However,
>> > it will be important once we add an actual width field to fs_reg.
>>
>> I don't really see the point to be honest. We just wind up calling the
>> constructor >1 time.
>>
>> I could see maybe see making them static members just to reduce their
>> scope.
>
>
> The point is to get a null register with a width of dispatch_width.  We need
> that later.

Ah, okay.

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list