[Mesa-dev] [PATCH 2/2] gallium/rbug: correctly unreference a sampler view

Marek Olšák maraeo at gmail.com
Mon Sep 22 14:18:44 PDT 2014


From: Marek Olšák <marek.olsak at amd.com>

This fixes heap corruption. The sampler view can be bound in the context,
so we cannot call destroy directly.
---
 src/gallium/drivers/rbug/rbug_objects.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/rbug/rbug_objects.c b/src/gallium/drivers/rbug/rbug_objects.c
index db18f2e..320f34d 100644
--- a/src/gallium/drivers/rbug/rbug_objects.c
+++ b/src/gallium/drivers/rbug/rbug_objects.c
@@ -153,8 +153,7 @@ rbug_sampler_view_destroy(struct rbug_context *rb_context,
                           struct rbug_sampler_view *rb_view)
 {
    pipe_resource_reference(&rb_view->base.texture, NULL);
-   rb_context->pipe->sampler_view_destroy(rb_context->pipe,
-                                          rb_view->sampler_view);
+   pipe_sampler_view_reference(&rb_view->sampler_view, NULL);
    FREE(rb_view);
 }
 
-- 
1.9.1



More information about the mesa-dev mailing list