[Mesa-dev] [PATCH 33/41] i965/fs: Use exec_size instead of force_uncompressed in dump_instruction

Matt Turner mattst88 at gmail.com
Tue Sep 23 11:20:20 PDT 2014


On Sat, Sep 20, 2014 at 10:23 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index e06e083..11f5323 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -3177,11 +3177,14 @@ fs_visitor::dump_instruction(backend_instruction *be_inst, FILE *file)
>
>     fprintf(file, " ");
>
> -   if (inst->force_uncompressed)
> -      fprintf(file, "1sthalf ");
> -
> -   if (inst->force_sechalf)
> -      fprintf(file, "2ndhalf ");
> +   if (inst->exec_size < 8) {
> +      fprintf(file, "%d-wide ", inst->exec_size);

I think it'd be better to just print the execution size in the
standard format (e.g., mov(8)).

> +   } else if (dispatch_width == 16 && inst->exec_size == 8) {
> +      if (inst->force_sechalf)
> +         fprintf(file, "2ndhalf ");
> +      else
> +         fprintf(file, "1sthalf ");
> +   }

This bit is good.


More information about the mesa-dev mailing list