[Mesa-dev] [PATCH 03/12] i965/fs: Rewrite fs_visitor::split_virtual_grfs

Matt Turner mattst88 at gmail.com
Tue Sep 23 20:40:04 PDT 2014


On Fri, Sep 19, 2014 at 1:10 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> The original vgrf splitting code was written assuming that with the
> assumption that vgrfs came in two types: those that can be split into
> single registers and those that can't be split at all It was very
> conservative and bailed as soon as more than one element of a register was
> read or written.  This won't work once we start allowing a regular MOV or
> ADD operation to operate on multiple registers.  This rewrite allows for
> the case where a vgrf of size 5 may appropreately be split in to one
> register of size 1 and two registers of size 2.

Having read the later series I now understand why we need to improve this pass.

I haven't followed all of the logic, but I trust it works as expected
if you've successfully tested a 41 patch series on top of it. :)

That's at least good enough for an

Acked-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list