[Mesa-dev] [PATCH 2/6] st/va: skeleton VAAPI state tracker

[Liu, Leo]

Hi Emil,


>-----Original Message-----
>From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
>Sent: Tuesday, September 23, 2014 3:49 PM
>To: Liu, Leo; mesa-dev at lists.freedesktop.org
>Cc: emil.l.velikov at gmail.com; Koenig, Christian
>Subject: Re: [Mesa-dev] [PATCH 2/6] st/va: skeleton VAAPI state tracker


......
>> +
>> +gallium_drv_video_la_LIBADD = \
>> +	$(top_builddir)/src/gallium/state_trackers/va/libvatracker.la \
>> +	$(top_builddir)/src/gallium/auxiliary/libgallium.la \
>> +	$(top_builddir)/src/util/libmesautil.la \
>> +	$(LIBVA_LIBS) \
>Unless I've missed something this link should not be needed. If in doubt just omit
>it, and let the _compiler_ shout about undefined symbols :)
>
>
If you talk about $(LIBVA_LIBS), we probably need it.
+    PKG_CHECK_MODULES([LIBVA], [libva >= 0.35.0 x11-xcb xcb-dri2 >= $XCBDRI2_REQUIRED])
Maybe I need change the name of "LIBVA" to "VA"

I will fix the rest in the v2.

Thanks,
Leo


>Cheers,
>Emil