[Mesa-dev] [PATCH 2/4] i965: Issue performance warnings on MapBufferRange stalls.

[Kenneth Graunke]

On Friday, August 29, 2014 11:10:48 PM Kenneth Graunke wrote:
> This is easy: we just need to use brw_map_bo instead of mapping it
> directly.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/intel_buffer_objects.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
> index 96dacde..fb806dc 100644
> --- a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
> +++ b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
> @@ -421,8 +421,8 @@ intel_bufferobj_map_range(struct gl_context * ctx,
>                                                            intel_obj->map_extra[index],
>                                                            alignment);
>        if (brw->has_llc) {
> -         drm_intel_bo_map(intel_obj->range_map_bo[index],
> -                          (access & GL_MAP_WRITE_BIT) != 0);
> +         brw_bo_map(brw, intel_obj->range_map_bo[index],
> +                    (access & GL_MAP_WRITE_BIT) != 0, "range-map");
>        } else {
>           drm_intel_gem_bo_map_gtt(intel_obj->range_map_bo[index]);
>        }
> @@ -438,7 +438,8 @@ intel_bufferobj_map_range(struct gl_context * ctx,
>        drm_intel_gem_bo_map_gtt(intel_obj->buffer);
>        intel_bufferobj_mark_inactive(intel_obj);
>     } else {
> -      drm_intel_bo_map(intel_obj->buffer, (access & GL_MAP_WRITE_BIT) != 0);
> +      brw_bo_map(brw, intel_obj->buffer, (access & GL_MAP_WRITE_BIT) != 0,
> +                 "MapBufferRange");
>        intel_bufferobj_mark_inactive(intel_obj);
>     }

It's been a month and patches 2-4 haven't received any review.  Could someone take a look?

Thanks,
--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140926/7c2afe7e/attachment.sig>