[Mesa-dev] [PATCH 14/15] radeonsi: release GS rings at context destruction

[Marek Olšák]

On Sat, Sep 27, 2014 at 8:02 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 27/09/14 18:29, Marek Olšák wrote:
>> There should be no warning on master. On master, the variables have
>> the pipe_resource type. On stable branches, the variables have the
>> pipe_constant_buffer type, so the expression should be changed to
>> &...ring->buffer. Without that, it probably crashes.
>>
> Perhaps I'm missing something here but according to
> include/pipe/p_state.h pipe_constant_buffer is defined as
>
> struct pipe_constant_buffer {
>    struct pipe_resource *buffer; /**< the actual buffer */
>    ...
> }
>
> Thus the original patch will provide struct pipe_resource** "masked" as
> struct pipe_constant_buffer*. So things are unlikely to crash.

You're right. I didn't remember how pipe_constant_buffer was laid out.

Marek