[Mesa-dev] [PATCH 1/4] st/mesa: remove unneded PIPE_TEXTURE_CUBE check in st_texture_create()

[Ilia Mirkin]

Series is Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

One more place I remember is in util_max_layer() which also
special-cases CUBE, where it could just be added to the *_ARRAY case.

On Mon, Sep 29, 2014 at 12:56 PM, Brian Paul <brianp at vmware.com> wrote:
> Earlier in the function we assert layers==6 for PIPE_TEXTURE_CUBE so
> there's no reason to special-case the pt.array_size = layers assignment.
> ---
>  src/mesa/state_tracker/st_texture.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_texture.c b/src/mesa/state_tracker/st_texture.c
> index 2cd95ec..5996b7d 100644
> --- a/src/mesa/state_tracker/st_texture.c
> +++ b/src/mesa/state_tracker/st_texture.c
> @@ -88,7 +88,7 @@ st_texture_create(struct st_context *st,
>     pt.width0 = width0;
>     pt.height0 = height0;
>     pt.depth0 = depth0;
> -   pt.array_size = (target == PIPE_TEXTURE_CUBE ? 6 : layers);
> +   pt.array_size = layers;
>     pt.usage = PIPE_USAGE_DEFAULT;
>     pt.bind = bind;
>     pt.flags = 0;
> --
> 1.7.10.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev