[Mesa-dev] [RFC PATCH 05/56] mesa/main: Add tessellation shader state and limits

Ian Romanick idr at freedesktop.org
Tue Sep 30 14:01:40 PDT 2014


On 09/30/2014 11:24 AM, Matt Turner wrote:
> On Tue, Sep 30, 2014 at 8:50 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 09/20/2014 07:41 PM, Matt Turner wrote:
>>> On Sat, Sep 20, 2014 at 6:40 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
>>>> diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
>>>> index 79d2e94..c11ad4f 100644
>>>> --- a/src/mesa/main/shaderapi.c
>>>> +++ b/src/mesa/main/shaderapi.c
>>>> @@ -105,6 +105,7 @@ _mesa_get_shader_flags(void)
>>>>  void
>>>>  _mesa_init_shader_state(struct gl_context *ctx)
>>>>  {
>>>> +   int i;
>>>
>>> In context, this declaration looks odd. Move it below the two just
>>> after this hunk?
>>
>> Not in core Mesa where we have to do dumb ol' C89. :(
> 
> Move it after the other two variable declarations...
> 
>    /* Device drivers may override these to control what kind of instructions
>     * are generated by the GLSL compiler.
>     */
>    struct gl_shader_compiler_options options;
>    gl_shader_stage sh;

Oh... yeah, that's fine.  I misunderstood you before.


More information about the mesa-dev mailing list