[Mesa-dev] [PATCH 1/5] i965/fs: Extend predicated break pass to predicate WHILE.

Ian Romanick idr at freedesktop.org
Tue Sep 30 14:32:51 PDT 2014


On 09/25/2014 09:00 AM, Matt Turner wrote:
> On Thu, Sep 25, 2014 at 8:25 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> How did you test this?  Do we have piglit execution tests that actually
>> hit this path?  I'm assuming you didn't play Serious Sam 3 looking for
>> rendering errors. ;)
> 
> I wrote the patch and initially missed the necessary predicate_inverse
> bit, and saw a bunch of piglit failures (hangs I think?). I checked
> the docs again and realized I needed to flip it, and then all of
> piglit passed.

Heh... okay.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>



More information about the mesa-dev mailing list