[Mesa-dev] [PATCH] gallivm: fix build for LLVM 3.2

[Brian Paul]

On 09/30/2014 03:34 PM, Mathias Fröhlich wrote:
>
> Hi,
>
> On Tuesday, September 30, 2014 21:25:54 Jose Fonseca wrote:
>> Your patch looks good AFAICT.
>>
>> Not sure why the crash, and I'm afraid I won't have time to look into it.
> I am currently looking into that.
>
>> I think it might help to '#define USE_MCJIT 1' for now, ie, enable MCJIT for all LLVM versions .  We were avoiding it on old LLVM versions, but AFAICT there's no longer any reason to avoid it now, and it might simplify get things working again.
>>
>> If things still don't work, then I think we should revert the recent LLVM changes, move them into a branch so we can investigate the issues with old LLVM more carefuly without blocking builds/tests on master.
>
> Reverting
>
> commit d90ff351f3a3598834f77b9c0723532b3abd3cd5
> Author: Mathias Fröhlich <Mathias.Froehlich at gmx.net>
> Date:   Sun Jul 13 12:49:41 2014 +0200
>
>      llvmpipe: Make a llvmpipe OpenGL context thread safe.
>
> is probably enough.
> I will just do so if I can't find the reason for the crash now.

Yeah, reverting that patch clears up the regression here.  Please go 
ahead and do the revert if you don't think you can solve the problem 
otherwise.  Thanks!

-Brian