[Mesa-dev] [PATCH 3/3] r600g: re-enable single-sample fast clear

[Dieter Nützel]

Am 02.08.2015 21:11, schrieb Marek Olšák:
> On Sun, Aug 2, 2015 at 9:03 PM, Dieter Nützel <Dieter at nuetzel-hh.de> 
> wrote:
>> Am 02.08.2015 19:54, schrieb Dieter Nützel:
>>> 
>>> Am 02.08.2015 15:36, schrieb Marek Olšák:
>>>> 
>>>> From: Marek Olšák <marek.olsak at amd.com>
>>>> 
>>>> Fixed by the CB_SHADER_MASK fix.
>>> 
>>> 
>>> Hurray,
>>> 
>>> r600g (Turks) ~10% performance drop for Mesa's 'objview' is _mostly_
>>> fixed.
>>> Mostly 'cause it is NOT on par as before (the 'broken') version.
>>> E.g. 'buddha' was stable at 600 FPS (see below).
>>> 
>>> Thanks,
>>>   Dieter
>> 
>> 
>> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
>> 
>> OK,
>> I retested with
>> git revert 97ec2c6 (r600g: disable single-sample fast color clear due 
>> to
>> hangs)
>> Speed is back (I put all three results together in the below table)
>> 
>> BTW I hadn't any hangs on Evergreen (Turks) with old version.
>> Any specific test I should try?
> 
> This test case hangs on my Redwood without the patches and fast clear 
> enabled:
> https://bugs.freedesktop.org/attachment.cgi?id=117466
> 
> Marek

OK,

all acked, now.
Your test case hangs on Evergreen (Turks) here, too.

[14644.548816] radeon 0000:01:00.0: ring 0 stalled for more than 
10248msec
[14644.548824] radeon 0000:01:00.0: GPU lockup (current fence id 
0x000000000026e33d last fence id 0x000000000026e33f on ring 0)
[14644.569069] [drm:r600_ib_test [radeon]] *ERROR* radeon: fence wait 
failed (-35).
[14644.569086] [drm:radeon_ib_ring_tests [radeon]] *ERROR* radeon: 
failed testing IB on GFX ring (-35).

But I could get logs and reboot...

With these patches and fast clear enabled _everything_ is GOOD.
Even SPEED! --- Only thing I had to do was a REBOOT.
Maybe one of the registers hold the OLD falue?

Commit, please.
Acked-by: Dieter Nützel <Dieter at nuetzel-hh.de>

Dieter

PS We all repeat loud:
A reboot now and then could make gfk development go...

bobcat.obj
1392.500000 FPS
1393.750000 FPS
1394.000000 FPS

buddha.obj
603.698425 FPS
600.250000 FPS
600.100098 FPS

bunny.obj
867.000000 FPS
863.534241 FPS
864.284058 FPS

GreatLakesBiplaneHP.obj
691.250000 FPS
688.827942 FPS
689.577759 FPS