[Mesa-dev] [PATCH 01/21] i965: Resolve GCC sign-compare warning.

[Matt Turner]

On Sun, Aug 2, 2015 at 11:09 PM, Rhys Kidd <rhyskidd at gmail.com> wrote:
> mesa/src/mesa/drivers/dri/i965/brw_draw.c: In function 'brw_postdraw_set_buffers_need_resolve':
> mesa/src/mesa/drivers/dri/i965/brw_draw.c:390:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>     for (int i = 0; i < fb->_NumColorDrawBuffers; i++) {
>                       ^
>
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
> index b5ef276..d57f502 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> @@ -387,7 +387,7 @@ static void brw_postdraw_set_buffers_need_resolve(struct brw_context *brw)
>        brw_render_cache_set_add_bo(brw, stencil_irb->mt->bo);
>     }
>
> -   for (int i = 0; i < fb->_NumColorDrawBuffers; i++) {
> +   for (GLuint i = 0; i < fb->_NumColorDrawBuffers; i++) {

We only want to use GL* types for API things. I.e., not here.