[Mesa-dev] [PATCH 20/21] i965: Resolve GCC sign-compare warning.

Ian Romanick idr at freedesktop.org
Wed Aug 5 09:10:30 PDT 2015


On 08/02/2015 11:09 PM, Rhys Kidd wrote:
> mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c: In function 'gen6_upload_push_constants':
> mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:85:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>        for (i = 0; i < prog_data->nr_params; i++) {
>                      ^
> mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:92:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>    for (i = 0; i < prog_data->nr_params; i++) {
>                  ^
> 
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/gen6_vs_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/gen6_vs_state.c b/src/mesa/drivers/dri/i965/gen6_vs_state.c
> index 35d10ef..b4836a2 100644
> --- a/src/mesa/drivers/dri/i965/gen6_vs_state.c
> +++ b/src/mesa/drivers/dri/i965/gen6_vs_state.c
> @@ -68,7 +68,7 @@ gen6_upload_push_constants(struct brw_context *brw,
>        _mesa_load_state_parameters(ctx, prog->Parameters);
>  
>        gl_constant_value *param;
> -      int i;
> +      uint32_t i;

Same comment here as the previous patch.

>  
>        param = brw_state_batch(brw, type,
>  			      prog_data->nr_params * sizeof(gl_constant_value),
> 



More information about the mesa-dev mailing list