[Mesa-dev] [PATCH v2 00/21] Resolve GCC sign-compare warnings patchset

Rhys Kidd rhyskidd at gmail.com
Wed Aug 5 23:33:56 PDT 2015


GCC warns on -Wsign-compare in a number of locations within i965.
This patchset goes a significant way to addressing these compiler warnings.

Changes have been made with preference to remain consistent with immediate
context of that file, rather than the whole patchset adopting one approach.

No piglit regressions on ILK.

v2: Thanks to code review by Matt Turner and Ian Romanick.

Rhys Kidd (21):
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  mesa: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  mesa/glx: Resolve GCC sign-compare warning.
  mesa/glx: Resolve GCC sign-compare warning.
  mesa/gbm: Resolve GCC sign-compare warning.
  mesa/egl: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965: Resolve GCC sign-compare warning.
  i965/gen6: Resolve GCC sign-compare warning.
  i965/gen7: Resolve GCC sign-compare warning.

 src/egl/drivers/dri2/platform_drm.c               | 10 +++++-----
 src/gbm/main/backend.c                            |  4 ++--
 src/glx/dri_common.c                              |  3 +--
 src/glx/dri_common_query_renderer.c               |  2 +-
 src/mesa/drivers/dri/common/utils.c               |  2 +-
 src/mesa/drivers/dri/i965/brw_draw.c              |  4 ++--
 src/mesa/drivers/dri/i965/brw_draw_upload.c       | 11 ++++++-----
 src/mesa/drivers/dri/i965/brw_primitive_restart.c |  2 +-
 src/mesa/drivers/dri/i965/brw_state_cache.c       |  2 +-
 src/mesa/drivers/dri/i965/brw_tex_layout.c        |  2 +-
 src/mesa/drivers/dri/i965/brw_vs_surface_state.c  |  2 +-
 src/mesa/drivers/dri/i965/brw_wm_state.c          |  2 +-
 src/mesa/drivers/dri/i965/brw_wm_surface_state.c  |  4 ++--
 src/mesa/drivers/dri/i965/gen6_vs_state.c         |  2 +-
 src/mesa/drivers/dri/i965/gen7_sol_state.c        |  2 +-
 src/mesa/drivers/dri/i965/intel_fbo.c             |  4 ++--
 src/mesa/drivers/dri/i965/intel_screen.c          |  8 ++++----
 17 files changed, 33 insertions(+), 33 deletions(-)

-- 
2.1.4



More information about the mesa-dev mailing list