[Mesa-dev] [Mesa-dev, 1/9] mesa/es3.1: Allow binding GL_DRAW_INDIRECT_BUFFER with gles 3.1

[Tapani Pälli]

On 07/31/2015 04:18 PM, Lofstedt, Marta wrote:
> Thanks Tapani,
>
> However,
>
> For patch 9 there is a V3 for which I can't see any new objections:
> http://patchwork.freedesktop.org/patch/51879/

This looks good to me.

> If you have any new ones could you please clarify.
>
> My interpretation of the comments on patch 6, is that it was OK as it is.
> Please clarify if you don't agree.

Yep it is ok, it looked strange at first. I tried to massage the 
equation to be 'more readable' but IMO only way would be to split it as 
multiple checks.

Both patches
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

>> -----Original Message-----
>> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
>> Behalf Of Tapani Pälli
>> Sent: Friday, July 31, 2015 10:28 AM
>> To: Marta Löfstedt; mesa-dev at lists.freedesktop.org
>> Subject: Re: [Mesa-dev] [Mesa-dev, 1/9] mesa/es3.1: Allow binding
>> GL_DRAW_INDIRECT_BUFFER with gles 3.1
>>
>> I've gone through this set (and using them regularly to be able to run 3.1es
>> conformance tests);
>>
>> Patches 1,2,3,4,5,7,8
>>
>> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>>
>> I believe with 6 and 9 there are changes required.
>>
>> On 05/11/2015 04:03 PM, Marta Löfstedt wrote:
>>> From: Marta Lofstedt <marta.lofstedt at intel.com>
>>>
>>> Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
>>>
>>> ---
>>> src/mesa/main/bufferobj.c | 5 +++--
>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
>>> index 66dee68..07f82cd 100644
>>> --- a/src/mesa/main/bufferobj.c
>>> +++ b/src/mesa/main/bufferobj.c
>>> @@ -91,8 +91,9 @@ get_buffer_target(struct gl_context *ctx, GLenum
>> target)
>>>       case GL_COPY_WRITE_BUFFER:
>>>          return &ctx->CopyWriteBuffer;
>>>       case GL_DRAW_INDIRECT_BUFFER:
>>> -      if (ctx->API == API_OPENGL_CORE &&
>>> -          ctx->Extensions.ARB_draw_indirect) {
>>> +      if ((ctx->API == API_OPENGL_CORE &&
>>> +           ctx->Extensions.ARB_draw_indirect) ||
>>> +           _mesa_is_gles31(ctx)) {
>>>             return &ctx->DrawIndirectBuffer;
>>>          }
>>>          break;
>>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev