[Mesa-dev] [PATCH 3/4] tnl: Maintain the _WindowMap matrix in TNLcontext v2.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Fri Aug 7 09:03:46 PDT 2015


On Friday, August 07, 2015 11:20:42 Ilia Mirkin wrote:
> Yeah, I tend to agree with you -- it seems like _tnl_wakeup is meant for
> "oh hey, I shut you down and haven't been sending you updates, but I want
> to use you again, so please update your stuff to match reality". Does it
> even need to be called at all? nouveau_state.c:nouveau_update_state
> unconditionally calls _tnl_InvalidateState. i965, on the other hand, the
> only other user of tnl_wakeup, calls it at draw time, for RenderMode !=
> GL_RENDER, and never calls _tnl_InvalidateState, so the tnl module is
> completely out-of-date there.
> So I'm actually in favor of removing it entirely. Thoughts?
You mean remove _tnl_wakeup/_tnl_InvalidateState entirely from the
nouveau initialzation? That may work - I have the same
impression, but I cannot exactly foresee what we might break.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150807/2cf9a228/attachment.html>

More information about the mesa-dev mailing list