[Mesa-dev] [PATCH v2 2/3] egl/x11: set EGL_BAD_NATIVE_(PIXMAP|WINDOW) for invalid pixmaps/windows

[Emil Velikov]

On 4 August 2015 at 14:32, Frank Binns <frank.binns at imgtec.com> wrote:
> Both eglCreatePixmapSurface and eglCreateWindowSurface were incorrectly
> setting the EGL error to be EGL_BAD_ALLOC when an invalid native drawable
> handle was being passed in. The EGL spec states the following for
> eglCreatePixmapSurface:
>
>         "If pixmap is not a valid native pixmap handle, then an EGL_BAD_-
>          NATIVE_PIXMAP error should be generated."
>
> (eglCreateWindowSurface has similar text)
>
> Correctly set the EGL error value based on xcb_get_geometry_reply returning
> an error structure containing something other than BadAlloc.
>
> v2: Check for BadAlloc error and update commit message to reflect this
>
> Signed-off-by: Frank Binns <frank.binns at imgtec.com>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil