[Mesa-dev] [PATCH 10/13] hash: Add _mesa_HashRemoveLocked() function.

Brian Paul brianp at vmware.com
Fri Aug 7 11:11:16 PDT 2015


On 08/07/2015 11:33 AM, Matt Turner wrote:
> On Fri, Aug 7, 2015 at 8:43 AM, Brian Paul <brianp at vmware.com> wrote:
>> On 08/06/2015 06:11 PM, Matt Turner wrote:
>>>
>>> ---
>>>    src/mesa/main/hash.c | 19 +++++++++++++++----
>>>    src/mesa/main/hash.h |  2 ++
>>>    2 files changed, 17 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
>>> index 315b5d6..aa1c6a1 100644
>>> --- a/src/mesa/main/hash.c
>>> +++ b/src/mesa/main/hash.c
>>> @@ -328,8 +328,8 @@ _mesa_HashInsert(struct _mesa_HashTable *table, GLuint
>>> key, void *data)
>>>     * While holding the hash table's lock, searches the entry with the
>>> matching
>>>     * key and unlinks it.
>>>     */
>>> -void
>>> -_mesa_HashRemove(struct _mesa_HashTable *table, GLuint key)
>>> +static inline void
>>> +_mesa_HashRemove_unlocked(struct _mesa_HashTable *table, GLuint key)
>>
>>
>> You can drop the _mesa_ prefix on static functions.
>
> Right, I think I named it that because existing static functions in
> that file use _mesa_:
>
> _mesa_HashInsert_unlocked
> _mesa_HashLookup_unlocked
>
> I can change them all if you like.

Sure.

-Brian




More information about the mesa-dev mailing list