[Mesa-dev] [PATCH] mesa/formats: Only do byteswapping for packed formats

[Oded Gabbay]

On Sat, Aug 8, 2015 at 7:04 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> Cc: Iago Toral <itoral at igalia.com>
> Cc: Oded Gabbay <oded.gabbay at gmail.com>
> ---
>  src/mesa/main/formats.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c
> index baeb1bf..d927073 100644
> --- a/src/mesa/main/formats.c
> +++ b/src/mesa/main/formats.c
> @@ -372,10 +372,10 @@ uint32_t
>  _mesa_format_to_array_format(mesa_format format)
>  {
>     const struct gl_format_info *info = _mesa_get_format_info(format);
> -   if (_mesa_little_endian())
> -      return info->ArrayFormat;
> -   else
> +   if (!_mesa_little_endian() && info->Layout == MESA_FORMAT_LAYOUT_PACKED)
>        return _mesa_array_format_flip_channels(info->ArrayFormat);
> +   else
> +      return info->ArrayFormat;
>  }
>
>  static struct hash_table *format_array_format_table;
> --
> 2.4.3
>
Your patch doesn't solve the original bug. Piglit sanity (and others)
still fail and screen capture is still wrong.

    Oded