[Mesa-dev] [PATCH] glsl: Add missing spec quote about atomic counter in structs

[Thomas Helland]

2015-08-09 6:46 GMT+02:00 Timothy Arceri <t_arceri at yahoo.com.au>:
> ---
>  src/glsl/ast_to_hir.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index 9385922..f67c951 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
> @@ -5679,10 +5679,10 @@ ast_process_structure_or_interface_block(exec_list *instructions,
>           }
>
>           if (field_type->contains_atomic()) {
> -            /* FINISHME: Add a spec quotation here once updated spec
> -             * FINISHME: language is available.  See Khronos bug #10903
> -             * FINISHME: on whether atomic counters are allowed in
> -             * FINISHME: structures.
> +            /* From section 4.1.7.3 of the GLSL 4.40 spec:
> +             *
> +             *    "Members of structures cannot be declared as atomic counter"
> +             *    " types."

Unintentionally "split string" due to your editor? With the nit fixed:

Reviewed-by: Thomas Helland <thomashelland90 at gmail.com>

>               */
>              YYLTYPE loc = decl_list->get_location();
>              _mesa_glsl_error(&loc, state, "atomic counter in structure, "
> --
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev