[Mesa-dev] [PATCH] mesa/es3.1: Enable GL_ARB_separate_shader_objects for GLES 3.1

[Lofstedt, Marta]

This patch has the wrong name also the MAX_VERTEX_ATTRIB_STRIDE was missing and this needs to go under a GLES 3.1 label.

I have sent a replacement patch for this:
http://patchwork.freedesktop.org/patch/56761/

/Marta

> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Matt Turner
> Sent: Tuesday, June 23, 2015 11:15 PM
> To: Marta Lofstedt
> Cc: mesa-dev at lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH] mesa/es3.1: Enable
> GL_ARB_separate_shader_objects for GLES 3.1
> 
> On Tue, Jun 23, 2015 at 4:30 AM, Marta Lofstedt
> <marta.lofstedt at linux.intel.com> wrote:
> > From: Marta Lofstedt <marta.lofstedt at intel.com>
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> > ---
> >  src/mesa/main/get_hash_params.py | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/mesa/main/get_hash_params.py
> > b/src/mesa/main/get_hash_params.py
> > index 74ff3ba..f7134a9 100644
> > --- a/src/mesa/main/get_hash_params.py
> > +++ b/src/mesa/main/get_hash_params.py
> > @@ -407,6 +407,10 @@ descriptor=[
> >  { "apis": ["GL", "GL_CORE", "GLES3"], "params": [  #
> > GL_ARB_sampler_objects / GL 3.3 / GLES 3.0
> >    [ "SAMPLER_BINDING", "LOC_CUSTOM, TYPE_INT,
> GL_SAMPLER_BINDING,
> > NO_EXTRA" ],
> > +
> > +# GL_ARB_vertex_attrib_binding / GLES 3.1
> > +  [ "MAX_VERTEX_ATTRIB_RELATIVE_OFFSET",
> > +"CONTEXT_ENUM(Const.MaxVertexAttribRelativeOffset), NO_EXTRA" ],
> > +  [ "MAX_VERTEX_ATTRIB_BINDINGS",
> > +"CONTEXT_ENUM(Const.MaxVertexAttribBindings), NO_EXTRA" ],
> 
> Won't this enable it in ES 3.0 as well? I think you need to replace NO_EXTRA
> with something that contains EXTRA_API_ES31. See
> extra_ARB_draw_indirect_es31 for an example.
> 
> >  ]},
> >
> >  # Enums in OpenGL Core profile and ES 3.1 @@ -776,10 +780,6 @@
> > descriptor=[
> >    [ "MAX_COMBINED_ATOMIC_COUNTER_BUFFERS",
> "CONTEXT_INT(Const.MaxCombinedAtomicBuffers),
> extra_ARB_shader_atomic_counters" ],
> >    [ "MAX_COMBINED_ATOMIC_COUNTERS",
> > "CONTEXT_INT(Const.MaxCombinedAtomicCounters),
> > extra_ARB_shader_atomic_counters" ],
> >
> > -# GL_ARB_vertex_attrib_binding
> > -  [ "MAX_VERTEX_ATTRIB_RELATIVE_OFFSET",
> > "CONTEXT_ENUM(Const.MaxVertexAttribRelativeOffset), NO_EXTRA" ],
> > -  [ "MAX_VERTEX_ATTRIB_BINDINGS",
> > "CONTEXT_ENUM(Const.MaxVertexAttribBindings), NO_EXTRA" ],
> > -
> >  # GL_ARB_shader_image_load_store
> >    [ "MAX_IMAGE_UNITS", "CONTEXT_INT(Const.MaxImageUnits),
> extra_ARB_shader_image_load_store"],
> >    [ "MAX_COMBINED_IMAGE_UNITS_AND_FRAGMENT_OUTPUTS",
> > "CONTEXT_INT(Const.MaxCombinedImageUnitsAndFragmentOutputs),
> > extra_ARB_shader_image_load_store"],
> > --
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev