[Mesa-dev] [PATCH] i965/skl: Remove early platform support

Ben Widawsky ben at bwidawsk.net
Mon Aug 10 09:49:36 PDT 2015

On Mon, Aug 10, 2015 at 09:09:41AM -0700, Jason Ekstrand wrote:
> On Aug 10, 2015 4:14 AM, "Neil Roberts" <neil at linux.intel.com> wrote:
> >
> > If we go with this patch perhaps it would be good to remove
> > supports_simd16_3src entirely from brw_device_info and any code that is
> > referring to it in order to avoid carrying around useless code.
> > Currently it seems like it would be quite easy to add a new
> > brw_device_info and forget to add supports_simd16_3src and never notice
> > that it is redundantly using the fallback.
> I would second that.

Either of you opposed to doing it as a follow-on patch? (This failure you speak
of was the primary goal for removing it). Initially, I tried to remove it, but
we do still seem to use this logic pre-HSW, and so things got messier than
I initially anticipated.

Neil, you said "if we go with this patch" - I haven't heard any opposition, do
you have any?


More information about the mesa-dev mailing list