[Mesa-dev] [PATCH 12/70] i965: Rename intel_batchbuffer to brw_batch

Jason Ekstrand jason at jlekstrand.net
Mon Aug 10 11:18:45 PDT 2015


On Mon, Aug 10, 2015 at 5:49 AM, Martin Peres
<martin.peres at linux.intel.com> wrote:
> On 10/08/15 15:45, Chris Wilson wrote:
>>
>> On Mon, Aug 10, 2015 at 03:37:24PM +0300, Martin Peres wrote:
>>>
>>> 10-12 are:
>>>
>>> Reviewed-by: Martin Peres <martin.peres at linux.intel.com>
>>
>> One thing to consider, do we want to do a s/typedef/struct brw_batch/
>> cleanup after the transition is complete?
>>
>> brw_batch vs struct brw_batch ?
>> brw_bo vs struct brw_bo ?
>> -Chris
>
>
> That is a question for jason and Kenneth, isn't it? /me is not really a big
> contributor to mesa yet

In most of mesa, we've kept the struct decorator.  We do typedefs in
NIR (which some people have complained about) but the rest of the time
we usually don't.  Of course, code that's written in C++ doesn't use
the "struct" keyword.
--Jason


More information about the mesa-dev mailing list