[Mesa-dev] [PATCH] i965/gen9: Don't use fast copy blit in case of non power of 2 cpp

Anuj Phogat anuj.phogat at gmail.com
Mon Aug 10 13:59:31 PDT 2015


On Mon, Aug 10, 2015 at 11:17 AM, Anuj Phogat <anuj.phogat at gmail.com> wrote:

> Many piglit tests (if using fast copy blit in Mesa) failed earlier
> because I missed adding this condition. Fast copy blit is currently
> enabled for use only with Yf/Ys tiling.
>
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/intel_blit.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_blit.c
> b/src/mesa/drivers/dri/i965/intel_blit.c
> index 6d92580..bab7d90 100644
> --- a/src/mesa/drivers/dri/i965/intel_blit.c
> +++ b/src/mesa/drivers/dri/i965/intel_blit.c
> @@ -431,8 +431,10 @@ can_fast_copy_blit(struct brw_context *brw,
>     if ((dst_offset | src_offset) & 63)
>        return false;
>
> -   /* Color depth greater than 128 bits not supported. */
> -   if (cpp > 16)
> +   /* Color depths which are not power of 2 or greater than 128 bits are
> +    * not supported.
> +    */
> +   if (!is_power_of_two(cpp) || cpp > 16)
>
 This function got deleted on master. I'll change it to _mesa_is_pow_two().

>        return false;
>
>     /* For Fast Copy Blits the pitch cannot be a negative number. So, bit
> 15
> --
> 2.4.3
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150810/593cfa0b/attachment.html>


More information about the mesa-dev mailing list