[Mesa-dev] [PATCH 1/2] r600g: fix polygon offset scale

Edward O'Callaghan edward.ocallaghan at koparo.com
Tue Aug 11 20:42:37 PDT 2015


Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>

-- 
  Edward O'Callaghan
  edward.ocallaghan at koparo.com

On Wed, Aug 12, 2015, at 09:02 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> The value was copied from r300g, which uses 1/12 subpixels, but this hw
> uses 1/16 subpixels.
> 
> Should fix piglit: gl-1.4-polygon-offset (formerly a glean test)
> (untested, ported from radeonsi)
> ---
>  src/gallium/drivers/r600/evergreen_state.c | 2 +-
>  src/gallium/drivers/r600/r600_state.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/r600/evergreen_state.c
> b/src/gallium/drivers/r600/evergreen_state.c
> index f7a76f6..95987ee 100644
> --- a/src/gallium/drivers/r600/evergreen_state.c
> +++ b/src/gallium/drivers/r600/evergreen_state.c
> @@ -485,7 +485,7 @@ static void *evergreen_create_rs_state(struct
> pipe_context *ctx,
>  
>  	/* offset */
>  	rs->offset_units = state->offset_units;
> -       rs->offset_scale = state->offset_scale * 12.0f;
> +       rs->offset_scale = state->offset_scale * 16.0f;
>  	rs->offset_enable = state->offset_point || state->offset_line || state->offset_tri;
>  
>  	if (state->point_size_per_vertex) {
> diff --git a/src/gallium/drivers/r600/r600_state.c
> b/src/gallium/drivers/r600/r600_state.c
> index 8488188..5cc2283 100644
> --- a/src/gallium/drivers/r600/r600_state.c
> +++ b/src/gallium/drivers/r600/r600_state.c
> @@ -473,7 +473,7 @@ static void *r600_create_rs_state(struct pipe_context
> *ctx,
>  
>  	/* offset */
>  	rs->offset_units = state->offset_units;
> -       rs->offset_scale = state->offset_scale * 12.0f;
> +       rs->offset_scale = state->offset_scale * 16.0f;
>  	rs->offset_enable = state->offset_point || state->offset_line || state->offset_tri;
>  
>  	if (state->point_size_per_vertex) {
> -- 
> 2.1.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list