[Mesa-dev] [PATCH] mesa/main: Add GL_IMAGE_FORMAT_COMPATIBILITY_TYPE to glGetTexParameterfv

[Lofstedt, Marta]

> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Francisco Jerez
> Sent: Wednesday, August 12, 2015 12:45 PM
> To: Marta Lofstedt; mesa-dev at lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH] mesa/main: Add
> GL_IMAGE_FORMAT_COMPATIBILITY_TYPE to glGetTexParameterfv
> 
> Marta Lofstedt <marta.lofstedt at linux.intel.com> writes:
> 
> > From: Marta Lofstedt <marta.lofstedt at intel.com>
> >
> > According to Open GL ES 3.1 specification, section 8.10.2.
> > GL_IMAGE_FORMAT_COMPATIBILITY_TYPE should be supported by
> > glGetTexParameterfv.
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> > ---
> >  src/mesa/main/texparam.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index
> > c0611c3..c05f45b 100644
> > --- a/src/mesa/main/texparam.c
> > +++ b/src/mesa/main/texparam.c
> > @@ -1890,6 +1890,12 @@ get_tex_parameterfv(struct gl_context *ctx,
> >           *params = (GLfloat) obj->Sampler.sRGBDecode;
> >           break;
> >
> > +      case GL_IMAGE_FORMAT_COMPATIBILITY_TYPE:
> > +         if (!ctx->Extensions.ARB_shader_image_load_store)
> > +            goto invalid_pname;
> > +         *params = (GLfloat) obj->ImageFormatCompatibilityType;
> > +         break;
> > +
> 
> Heh, I had exactly the same patch sitting in a local branch of GLES fixes for
> image_load_store, but you beat me to it, this patch is:

Sorry! 

Thanks for review!

> 
> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
> 
> >        default:
> >           goto invalid_pname;
> >     }
> > --
> > 1.9.1
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev